RE: [PATCH v5 2/4] lib/vsprintf.c: make '%pD' print the full path of file

Hi Petr

-----Original Message-----
From: Petr Mladek <pmladek@suse.com>
Sent: Thursday, June 24, 2021 4:47 PM
To: Justin He <redacted>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; Steven Rostedt
[off-list ref]; Sergey Senozhatsky [off-list ref];
Rasmus Villemoes [off-list ref]; Jonathan Corbet
[off-list ref]; Alexander Viro [off-list ref]; Linus Torvalds
[off-list ref]; Peter Zijlstra (Intel)
[off-list ref]; Eric Biggers [off-list ref]; Ahmed S.
Darwish [off-list ref]; linux-doc@vger.kernel.org; linux-
kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; Matthew Wilcox
[off-list ref]; Christoph Hellwig [off-list ref]; nd
[off-list ref]
Subject: Re: [PATCH v5 2/4] lib/vsprintf.c: make '%pD' print the full path
of file

On Wed 2021-06-23 03:14:33, Justin He wrote:

quoted

Hi Andy

quoted

-----Original Message-----
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Sent: Tuesday, June 22, 2021 10:40 PM
To: Justin He <redacted>
Cc: Petr Mladek <pmladek@suse.com>; Steven Rostedt

[off-list ref];

quoted

quoted

Sergey Senozhatsky [off-list ref]; Rasmus Villemoes
[off-list ref]; Jonathan Corbet [off-list ref]; Alexander
Viro [off-list ref]; Linus Torvalds <torvalds@linux-
foundation.org>; Peter Zijlstra (Intel) [off-list ref]; Eric
Biggers [off-list ref]; Ahmed S. Darwish

[off-list ref];

quoted

quoted

linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
fsdevel@vger.kernel.org; Matthew Wilcox [off-list ref];

Christoph

quoted

quoted

Hellwig [off-list ref]; nd [off-list ref]
Subject: Re: [PATCH v5 2/4] lib/vsprintf.c: make '%pD' print the full

path

quoted

quoted

of file

On Tue, Jun 22, 2021 at 10:06:32PM +0800, Jia He wrote:

quoted

Previously, the specifier '%pD' is for printing dentry name of struct
file. It may not be perfect (by default it only prints one component.)

As suggested by Linus [1]:

Citing is better looked when you shift right it by two white spaces.

Okay, I plan to cite it with "> "

My understanding is that Andy suggested to omit '>' and prefix it by
plain two spaces "  ". It would look better to me as well.

Okay, got it


--
Cheers,
Justin (Jia He)