RE: [PATCH v5 0/4] make '%pD' print the full path of file

Hi Andy

-----Original Message-----
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Sent: Tuesday, June 22, 2021 10:43 PM
To: Justin He <redacted>
Cc: Petr Mladek <pmladek@suse.com>; Steven Rostedt <rostedt@goodmis.org>;
Sergey Senozhatsky [off-list ref]; Rasmus Villemoes
[off-list ref]; Jonathan Corbet [off-list ref]; Alexander
Viro [off-list ref]; Linus Torvalds <torvalds@linux-
foundation.org>; Peter Zijlstra (Intel) [off-list ref]; Eric
Biggers [off-list ref]; Ahmed S. Darwish [off-list ref];
linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
fsdevel@vger.kernel.org; Matthew Wilcox [off-list ref]; Christoph
Hellwig [off-list ref]; nd [off-list ref]
Subject: Re: [PATCH v5 0/4] make '%pD' print the full path of file

On Tue, Jun 22, 2021 at 10:06:30PM +0800, Jia He wrote:

quoted

Background
==========
Linus suggested printing the full path of file instead of printing
the components as '%pd'.

Typically, there is no need for printk specifiers to take any real locks
(ie mount_lock or rename_lock). So I introduce a new helper d_path_fast
which is similar to d_path except it doesn't take any seqlock/spinlock.

This series is based on Al Viro's d_path cleanup patches [1] which
lifted the inner lockless loop into a new helper.

Link: https://lkml.org/lkml/2021/5/18/1260 [1]

Test
====
The cases I tested:
1. print '%pD' with full path of ext4 file
2. mount a ext4 filesystem upon a ext4 filesystem, and print the file
   with '%pD'
3. all test_print selftests, including the new '%14pD' '%-14pD'

quoted

4. kasnprintf

I believe you are talking about kasprintf().

quoted

Changelog
=========
v5:
- remove the RFC tag

JFYI, when we drop RFC we usually start the series from v1.

quoted

- refine the commit msg/comments(by Petr, Andy)
- make using_scratch_space a new parameter of the test case

Thanks for the update, I have found few minor things, please address them
and
feel free to add
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

I assume I can add your R-b to patch 4/4 "add test cases for '%pD'" instead of
whole series, right?

--
Cheers,
Justin (Jia He)