On 6/18/21 9:04 PM, Steven Rostedt wrote:

On Tue, 15 Jun 2021 11:28:51 +0200
Daniel Bristot de Oliveira [off-list ref] wrote:

quoted

@@ -1566,7 +1627,14 @@ osnoise_cpus_write(struct file *filp, const char __user *ubuf, size_t count,
 		osnoise_tracer_stop(tr);
 
 	mutex_lock(&interface_lock);
+	/*
+	 * osnoise_cpumask is ready by CPU hotplug operations.

I don't understand the usage of "ready" above. Lost in translation?

	 * osnoise_cpumask is updated by CPU hotplug operations.

I think I meant "read"... I will use your comment.

Thanks

-- Daniel

?

-- Steve

quoted

+	 */
+	get_online_cpus();
+
 	cpumask_copy(&osnoise_cpumask, osnoise_cpumask_new);
+
+	put_online_cpus();
 	mutex_unlock(&interface_lock);