Thread (28 messages) 28 messages, 2 authors, 2021-06-22

Re: [PATCH V4 10/12] trace: Add osnoise tracer

From: Daniel Bristot de Oliveira <hidden>
Date: 2021-06-21 12:09:51
Also in: lkml

On 6/18/21 8:27 PM, Steven Rostedt wrote:
On Tue, 15 Jun 2021 11:28:49 +0200
Daniel Bristot de Oliveira [off-list ref] wrote:
quoted
diff --git a/kernel/trace/trace_osnoise.h b/kernel/trace/trace_osnoise.h
new file mode 100644
index 000000000000..34c7b80f9e12
--- /dev/null
+++ b/kernel/trace/trace_osnoise.h
@@ -0,0 +1,9 @@
+int __weak osnoise_arch_register(void)
+{
+	return 0;
+}
+
+void __weak osnoise_arch_unregister(void)
+{
+	return;
+}
No reason to put the above in a header file. In fact, as it is code, it
should not be in a header file. Keep it in the trace_osnoise.c.
Ack!

-- Daniel
-- Steve
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help