Thread (53 messages) 53 messages, 11 authors, 2022-06-25

Re: [PATCH v3 11/14] intel_gna: add ioctl handler

From: Matthew Wilcox <willy@infradead.org>
Date: 2021-05-13 14:19:00
Also in: lkml

On Thu, May 13, 2021 at 01:00:37PM +0200, Maciej Kwapulinski wrote:
+#include <linux/idr.h>
Please don't use the IDR in new code.  Use the XArray instead.
+	mutex_lock(&gna_priv->memidr_lock);
+	mo = idr_find(&gna_priv->memory_idr, memory_id);
+	mutex_unlock(&gna_priv->memidr_lock);
You don't need your own lock with the XArray.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help