Thread (53 messages) 53 messages, 11 authors, 2022-06-25

Re: [PATCH v3 01/14] intel_gna: add driver module

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-05-13 11:13:50
Also in: lkml

On Thu, May 13, 2021 at 01:00:27PM +0200, Maciej Kwapulinski wrote:
+#ifdef CONFIG_DEBUG_INTEL_GNA
+module_param(recovery_timeout, int, 0644);
+MODULE_PARM_DESC(recovery_timeout, "Recovery timeout in seconds");
+#endif
This is not the 1990's, please no new module parameters ever.  If you
only need this for "debugging" then use debugfs, that's exactly what it
is for.

But really, shouldn't this "just work" and not require someone to change
this by hand?

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help