Re: [PATCH v1 3/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys
From: Richard Weinberger <hidden>
Date: 2021-03-16 23:15:58
Also in:
keyrings, linux-crypto, linux-integrity, linux-security-module, lkml
Ahmad, On Tue, Mar 16, 2021 at 6:24 PM Ahmad Fatoum [off-list ref] wrote:
quoted hunk ↗ jump to hunk
+#include <keys/trusted_caam.h> +#include <keys/trusted-type.h> +#include <linux/build_bug.h> +#include <linux/key-type.h> +#include <soc/fsl/caam-blob.h> + +struct caam_blob_priv *blobifier;
Who is using this pointer too? Otherwise I'd suggest marking it static.
quoted hunk ↗ jump to hunk
module_param_named(source, trusted_key_source, charp, 0); -MODULE_PARM_DESC(source, "Select trusted keys source (tpm or tee)"); +MODULE_PARM_DESC(source, "Select trusted keys source (tpm, tee or caam)");
I didn't closely follow the previous discussions, but is a module parameter really the right approach? Is there also a way to set it via something like device tree? -- Thanks, //richard