Thread (20 messages) 20 messages, 4 authors, 2021-02-26

Re: [PATCH v4 1/4] PCI: Introduce pcim_alloc_irq_vectors()

From: Robert Richter <rric@kernel.org>
Date: 2021-02-19 15:02:45
Also in: linux-i2c, linux-pci, lkml

On 19.02.21 16:48:57, Andy Shevchenko wrote:
On Fri, Feb 19, 2021 at 03:40:05PM +0100, Robert Richter wrote:
quoted
On 18.02.21 23:04:55, Dejin Zheng wrote:
quoted
Introduce pcim_alloc_irq_vectors(), a device-managed version of
pci_alloc_irq_vectors(). Introducing this function can simplify
the error handling path in many drivers.

And use pci_free_irq_vectors() to replace some code in pcim_release(),
they are equivalent, and no functional change. It is more explicit
that pcim_alloc_irq_vectors() is a device-managed function.
...
quoted
If it is just about having a pcim-* counterpart why not just an inline
function like the one below.
It's a good suggestion, thanks!

Still we need to amend pcim_release() to explicitly show that we call
pci_free_irq_vectors().
Fair enough. Thanks,

-Robert
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help