Thread (48 messages) 48 messages, 8 authors, 2020-01-20

Re: [PATCH v3 2/7] gpiolib: Add support for gpiochipN-based table lookup

From: Linus Walleij <hidden>
Date: 2019-12-12 14:36:49
Also in: linux-devicetree, linux-gpio, linux-renesas-soc, lkml, qemu-devel

On Thu, Dec 12, 2019 at 2:33 PM Geert Uytterhoeven [off-list ref] wrote:
On Thu, Dec 12, 2019 at 2:20 PM Linus Walleij [off-list ref] wrote:
quoted
On Wed, Nov 27, 2019 at 9:43 AM Geert Uytterhoeven
[off-list ref] wrote:
quoted
Currently GPIO controllers can only be referred to by label in GPIO
lookup tables.

Add support for looking them up by "gpiochipN" name, with "N" either the
corresponding GPIO device's ID number, or the GPIO controller's first
GPIO number.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
What the commit message is missing is a rationale, why is this needed?
Right. To be added: so they can be looked up in the GPIO lookup table
using either the chip's label, or the "gpiochipN" name.
After reading the aggregator/forwarder driver I am not convinced
that this is needed at all and I think this patch can be dropped,
but check my review and see what you think!

Thanks,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help