Re: [PATCH v3 3/4] ASoC: es9039q2m: add ESS Technology ES9039Q2M codec driver
From: Karl Asseily <hidden>
Date: 2026-09-18 18:27:50
Also in:
sashiko-reviews
[Severity: Low] Can we use named initializers for this array? The I2C subsystem requires explicitly named initializers for struct i2c_device_id arrays to ensure proper device matching.
Not taken, and I do not think the premise holds. Measured against
broonie/sound for-next: sound/soc/codecs carries 202 i2c_device_id
tables, and 136 of their entries use the plain positional form
{ "name", data }, which is not a named initializer at all. The bare
{ "name" } this driver uses accounts for 196 more. Matching does not
read the initializer syntax - i2c_match_id() compares the name string -
so the form has no bearing on device matching.
The other three findings were real and are all fixed in v4, which is on
the list now. Thank you for them - the FIR-versus-suspend one was a
genuine bug.