Re: [PATCH v3 2/4] ASoC: dt-bindings: add ESS Technology ES9039Q2M
From: sashiko-bot@kernel.org
Date: 2026-09-18 03:20:48
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] dt-bindings: esstech,es9039q2m: missing power supply properties -- commit 319b6af08837af1db6a259282cc4b550059341ed Author: Karl Asseily [off-list ref] ASoC: dt-bindings: add ESS Technology ES9039Q2M Add a binding for the ES9039Q2M, a 32-bit two-channel audio DAC with an asynchronous sample rate converter.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/sound/esstech,es9039q2m.yaml b/Documentation/devicetree/bindings/sound/esstech,es9039q2m.yaml new file mode 100644 index 0000000000000..c1d03d3a85527 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/esstech,es9039q2m.yaml
[ ... ]
+properties: + compatible: + const: esstech,es9039q2m + + reg: + description: + I2C address, selected by the ADDR0 and ADDR1 pins - 0x48, 0x49, 0x4a or + 0x4b for GND/GND, GND/AVDD, AVDD/GND and AVDD/AVDD respectively.
[Severity: Medium] Should there be a property for the AVDD power supply in this binding? The description explicitly mentions the AVDD pin, confirming the hardware utilizes power supplies that are not modeled as properties in the schema. Without them, device trees cannot properly model the analogue and digital power supplies of the hardware. If the supplies are dynamically managed, the lack of properties prevents describing this topology, potentially leaving the device unpowered on systems where the bootloader does not leave them enabled. Adding them as required properties later would break backward compatibility with device trees written against this initial schema.
+ enum: [ 0x48, 0x49, 0x4a, 0x4b ] + + clocks: + maxItems: 1
-- Sashiko AI review · https://sashiko.dev/#/patchset/20260918031326.68542-1-karl@asseily.com?part=2