Re: [PATCH 3/9] dt-bindings: display: novatek,nt36672a: Add 5 new panels
From: sashiko-bot@kernel.org
Date: 2026-09-13 06:32:47
Also in:
dri-devel
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Low] Incomplete Documentation Update - [Low] Alphabetical ordering violation in compatible strings -- commit fe459608210d248fe11d7e07e8ba300ec1c7b36a Author: Alexey Minnekhanov [off-list ref] dt-bindings: display: novatek,nt36672a: Add 5 new panels This commit documents 5 new display panels that use the Novatek NT36672A driver. These panels are used in various smartphones produced by Xiaomi and ASUS.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml index 5d16d85117254..3671fd788a818 100644 --- a/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml@@ -22,7 +22,12 @@ properties: compatible: items: - enum:
[Severity: Low] Could the main description block be updated to reflect these additions? The top-level description property for novatek,nt36672a.yaml currently says "Right now, support is added only for a Tianma FHD+ LCD display panel with a resolution of 1080x2246." Since this commit adds 5 new panels to the compatible items enum below, the description is now outdated.
+ - shenchao,fhdplus-video
- tianma,fhd-video
+ - tianma,tl060fvxs16-00
+ - tianma,tl063fvmca01-00
+ - tianma,tl063fvmc43-02[Severity: Low] Is it possible to sort these compatible strings alphabetically? In ASCII, the character 4 comes before a, so it seems like "tianma,tl063fvmc43-02" should precede "tianma,tl063fvmca01-00" in this enum list.
+ - txd,txdi600yanpa-43v3
- const: novatek,nt36672a
description: This indicates the panel manufacturer of the panel that is
in turn using the NT36672A panel driver. This compatible string-- Sashiko AI review · https://sashiko.dev/#/patchset/20260913-nt36672a-panels-v1-0-ce097402c6ea@minlexx.ru?part=3