Re: [PATCH 2/9] dt-bindings: vendor-prefixes: Add Shenzhen Zhuohong Electronic
From: sashiko-bot@kernel.org
Date: 2026-09-13 06:31:13
Also in:
dri-devel
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Vendor prefix mismatch: 'shenchao' mapped to 'Shenzhen Zhuohong Electronic Technology Co., Ltd.' -- commit 73f96d396aaa9d9d8dc1a660e32b98910c8690b8 Author: Alexey Minnekhanov [off-list ref] dt-bindings: vendor-prefixes: Add Shenzhen Zhuohong Electronic This commit adds a new vendor prefix to the device tree bindings. It aims to register Shenzhen Zhuohong Electronic Technology Co., Ltd., a manufacturer of LCD/IPS displays.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml@@ -1507,6 +1507,8 @@ patternProperties: description: SGX Sensortech "^sharp,.*": description: Sharp Corporation + "^shenchao,.*": + description: Shenzhen Zhuohong Electronic Technology Co., Ltd.
[Severity: Low] Is this vendor prefix mapped to the correct company description? The patch introduces the 'shenchao' prefix, but maps it to Shenzhen Zhuohong Electronic Technology Co., Ltd. Since 'shenchao' typically refers to a Shenchao panel (as seen in a subsequent commit introducing the 'shenchao,fhdplus-video' panel), mapping it to Zhuohong, a different panel manufacturer, could cause confusion for device tree authors. Should this prefix be named something like '^zhuohong,.*' instead to match the manufacturer, or should the description be updated to reflect the actual Shenchao company name? -- Sashiko AI review · https://sashiko.dev/#/patchset/20260913-nt36672a-panels-v1-0-ce097402c6ea@minlexx.ru?part=2