Re: [PATCH v5 1/6] PCI: spacemit-k1: Add device data support

On Tue, Sep 08, 2026 at 01:26:44PM +0300, Andy Shevchenko wrote:

On Mon, Sep 07, 2026 at 07:26:00PM +0800, Inochi Amaoto wrote:

quoted

To reuse the K1 PCIe driver logic for K3 PCIe controller, add device
data to handle the K1 specific logic and make room for the incoming
logic for K3.

...

quoted

 static int k1_pcie_probe(struct platform_device *pdev)
 {
+	const struct k1_pcie_device_data *data;
 	struct device *dev = &pdev->dev;
 	struct k1_pcie *k1;
 	int ret;
 
+	data = device_get_match_data(dev);
+	if (!data)
+		return -ENODEV;

It's better to use -ENODATA which will help to distinguish from other ENODEV
cases (which are more often to happen).

OK, thanks

quoted

 	k1 = devm_kzalloc(dev, sizeof(*k1), GFP_KERNEL);
 	if (!k1)
 		return -ENOMEM;

-- 
With Best Regards,
Andy Shevchenko