Re: [PATCH v4 2/2] pinctrl: qcom: Add MSM8952 tlmm pinctrl driver

Hi Konrad,

On Mon, 7 Sep 2026 14:04:59 +0200, Konrad Dybcio wrote:

On 04-Sep-26 14:55, Muzaffer Kadir via B4 Relay wrote:
I told the robot to take a look again (and again and again
a couple more times until it stopped complaining)..

The following feedback is meaningful:

Hi Muzaffer,

  `qdss_tracedata_b_groups` advertises GPIOs that cannot actually select
  the function. Please populate the corresponding PINGROUP slots:

    GPIO8:  mux 11
    GPIO9:  mux 12
    GPIO12: mux 12
    GPIO13: mux 12

I will add these to their pins by sending v5.

But also I want to ask,
does atest_combodac_to_gpio_native
have any mux on gpio12/13/20/21/29/30 ?Or are they wrongly set ?

  Minor nit: use MODULE_LICENSE("GPL") to match the nearby Qualcomm
  pinctrl drivers. // and checkpatch will ask you to do the same

Some of the upstream pinctrl drivers were
using "GPL v2", so I wasn't sure about that.
I will change this to GPL in v5.
Thanks a lot for review.

Best regards,
Muzaffer Kadir