Re: [PATCH v4 1/2] dt-bindings: pinctrl: qcom: Add MSM8952 pinctrl
From: sashiko-bot@kernel.org
Date: 2026-09-04 13:05:41
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The `maxItems` limit for `gpio-reserved-ranges` is mathematically off-by-one, artificially preventing the maximum possible fragmentation of reserved ranges. -- commit c09a958e0a0865ed0afbe7d8e7ad728062dcbdf7 Author: Muzaffer Kadir [off-list ref] dt-bindings: pinctrl: qcom: Add MSM8952 pinctrl Add device tree bindings for the TLMM pin controller found on the Qualcomm MSM8952 platform.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8952-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8952-pinctrl.yaml new file mode 100644 --- /dev/null +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8952-pinctrl.yaml@@ -0,0 +1,146 @@
[ ... ]
+ interrupts: + maxItems: 1 + + gpio-reserved-ranges: + minItems: 1 + maxItems: 66
[Severity: Low] Does this maxItems limit artificially prevent the maximum possible fragmentation of reserved ranges? The SoC defines 134 GPIO pins (0 through 133). In the worst-case fragmentation scenario where every alternating pin is reserved (e.g., 0, 2, 4, ..., 132), wouldn't this result in exactly 67 disjoint reserved ranges rather than 66? -- Sashiko AI review · https://sashiko.dev/#/patchset/20260904-msm8952-pinctrl-v4-0-671475ed1397@mainlining.org?part=1