Re: [PATCH v4 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells
flat view
From: Conor Dooley <conor@kernel.org>
Date: 2026-08-28 15:58:10
Also in:
linux-arm-kernel, lkml
On Fri, Aug 28, 2026 at 05:11:14PM +0200, Marek Vasut wrote:
quoted hunk ↗ jump to hunk
The st,stm32mp23-syscfg and st,stm32mp25-syscfg can have subnodes, which represent the USB 2.0 FEMTO-PHY. Document subnodes pattern properties and address/size cells. Signed-off-by: Marek Vasut <redacted> --- Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> Cc: Christophe Roullier <redacted> Cc: Conor Dooley <conor+dt@kernel.org> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> Cc: Marek Vasut <redacted> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> Cc: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com> Cc: Rob Herring <robh@kernel.org> Cc: Yannick Fertre <yannick.fertre@foss.st.com> Cc: devicetree@vger.kernel.org Cc: kernel@dh-electronics.com Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com --- V2: New patch V3: Fix the bindings V4: - Undo simple-mfd in favor of dedicated SYSCFG SoC driver - Update commit message to match, this used to be patch dt-bindings: arm: stm32: Switch st,stm32mp23/25-syscfg into simple-mfd - Split this from series arm64: dts: phy: st: usb: Add STM32MP2 USB support https://lore.kernel.org/all/20260822074816.548662-1-marex@nabladev.com/ (local) --- .../bindings/arm/stm32/st,stm32-syscon.yaml | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml index 95d2319afe235..d82afa39960b9 100644 --- a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml +++ b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml@@ -39,6 +39,17 @@ properties: "#clock-cells": const: 0 + "#address-cells": + const: 1 + + "#size-cells": + const: 1 + +patternProperties: + "^phy@[0-9a-f]+$": + type: object + $ref: /schemas/phy/st,stm32-usb2phy.yaml + required: - compatible - reg@@ -57,10 +68,14 @@ allOf: - if: properties: compatible: - const: st,stm32mp25-syscfg + enum: + - st,stm32mp23-syscfg + - st,stm32mp25-syscfg
Sashiko comment here I believe is valid, the syntax here only works if there's only the listed compatible present. It doesn't work with fallbacks. pw-bot: changes-requested
quoted hunk ↗ jump to hunk
then: required: - "#clock-cells" + - "#address-cells" + - "#size-cells"
else, false? But I'm also not sure what the benefit is of requiring addr/size cells when the child node is not? Cheers, Conor.
additionalProperties: false -- 2.53.0
Attachments
- signature.asc [application/pgp-signature] 228 bytes