Thread (23 messages) 23 messages, 5 authors, 2026-08-19

Re: [PATCH v4 6/6] iio: dac: ad5504: support scale via output-range-microvolt property

flat view

From: Taha Ed-Dafili <hidden>
Date: 2026-08-18 08:24:02
Also in: linux-iio, lkml

On Mon, Aug 18, 2026 at 06:30:00AM +0300, Andy Shevchenko wrote:
We do not need a Dostoevsky novel in the commit message. Please, make
it straight to the point. Don't blindly use AI, you should understand
what the code is doing. Same comment to all commit messages in the
series.
Understood, will trim all commit messages in v5. My workflow is to
draft the messages myself then use AI to check clarity and kernel
mailing list conventions. I'll make sure that doesn't result in
over-explained prose going forward.
So, the change from 1000 to MILLI is in the line that is changed
again in this patch. So, no need to change it earlier. And again, it
should be (MICRO / MILLI).
I started the code with a bare / 1000, then replaced it with MILLI
thinking it was the more readable form. I wasn't aware of the
(MICRO / MILLI) idiom for expressing unit conversions explicitly.
Will fix in v5 and drop the intermediate change from patch 5.

Best Regards,
Taha Ed-dafili
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help