Re: [PATCH 1/8] dt-bindings: phy: Document ST STM32MP25 USB2-FEMTO PHY
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-08-12 10:15:37
Also in:
linux-arm-kernel, linux-phy, linux-usb, lkml
On Wed, Aug 12, 2026 at 02:55:41AM +0200, Marek Vasut wrote:
From: Pankaj Dev <redacted> Document USB2 PHY for STM32MP25 USB2 controllers, which includes the USB2.0 host-only controller and USB 2.0 part of the DWC3 controller. Two such PHYs in total are present in STM32MP25 SoC, they both are slightly different, therefore they use different compatible string
What is slightly different? This should be either here, or better, in "description" part.
to discern them. Signed-off-by: Clément Le Goffic <redacted> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com> Signed-off-by: Marek Vasut <redacted> Signed-off-by: Pankaj Dev <redacted> Signed-off-by: Rahul Kumar <redacted>
Incomplete/incorrect DCO chain. Who sends it? Rahul?
quoted hunk ↗ jump to hunk
--- Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> Cc: Christian Bruel <christian.bruel@foss.st.com> Cc: Conor Dooley <conor+dt@kernel.org> Cc: Fabrice Gasnier <fabrice.gasnier@foss.st.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> Cc: Neil Armstrong <neil.armstrong@linaro.org> Cc: Pankaj Dev <redacted> Cc: Rahul Kumar <redacted> Cc: Rob Herring <robh@kernel.org> Cc: Rosen Penev <redacted> Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com> Cc: Vinod Koul <vkoul@kernel.org> Cc: devicetree@vger.kernel.org Cc: kernel@dh-electronics.com Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: linux-phy@lists.infradead.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-usb@vger.kernel.org --- .../bindings/phy/st,stm32-usb2phy.yaml | 72 +++++++++++++++++++ 1 file changed, 72 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/st,stm32-usb2phy.yamldiff --git a/Documentation/devicetree/bindings/phy/st,stm32-usb2phy.yaml b/Documentation/devicetree/bindings/phy/st,stm32-usb2phy.yaml new file mode 100644 index 0000000000000..ca9fc3b87383c --- /dev/null +++ b/Documentation/devicetree/bindings/phy/st,stm32-usb2phy.yaml@@ -0,0 +1,72 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/st,stm32-usb2phy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: STMicroelectronics STM32 MPU High-Speed USB PHY + +description: + USB2 PHY block in STM32 is attached to USB 2.0 Host controller and + USB 2.0 side of DWC3 DRD controller, and provides the USB LS/FS/HS + connectivity. + +maintainers: + - Fabrice Gasnier <fabrice.gasnier@foss.st.com> + - Marek Vasut <marex@nabladev.com> + - Pankaj Dev <pankaj.dev@st.com> + +properties: + compatible: + enum: + - st,stm32mp25-usb2phy1 + - st,stm32mp25-usb2phy2 + + "#phy-cells": + const: 0 + + clocks: + maxItems: 1 + + resets: + maxItems: 1 + + vdd33-supply: + description: Phandle to regulator providing 3V3 power supply to the USB2 HS PHY + + st,syscfg: + $ref: /schemas/types.yaml#/definitions/phandle-array + description: Phandle to system configuration controller. + items: + - items: + - description: phandle to syscfg + - description: USB2PHY control offset within syscfg + + "#clock-cells": + const: 0 + +required: + - compatible + - "#clock-cells" + - "#phy-cells" + - clocks + - resets + - st,syscfg + - vdd33-supply + +unevaluatedProperties: false
additionalProperties. Best regards, Krzysztof