Re: [PATCH 5/8] dt-bindings: usb: dwc3: Document ST STM32MP2 DWC3 xHCI USB controller
From: sashiko-bot@kernel.org
Date: 2026-08-12 01:08:57
Also in:
linux-phy
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Medium] Missing reference to DWC3 core schema causes valid USB properties to be rejected. - [Low] The `resets` property is missing a `maxItems` constraint. --
--- Patch [5]: [PATCH 5/8] dt-bindings: usb: dwc3: Document ST STM32MP2 DWC3 xHCI USB controller ---commit df84943476bf67384e16624668aaadbaba67875b Author: Marek Vasut [off-list ref] dt-bindings: usb: dwc3: Document ST STM32MP2 DWC3 xHCI USB controller The ST STM32MP2 SoC contains single instance of DWC3 USB controller with glue logic wrapper around it controlled by syscon. Document the glue logic and DWC3 controller.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/usb/st,stm32mp25-dwc3.yaml b/Documentation/devicetree/bindings/usb/st,stm32mp25-dwc3.yaml new file mode 100644 index 0000000000000..e377efef43503 --- /dev/null +++ b/Documentation/devicetree/bindings/usb/st,stm32mp25-dwc3.yaml@@ -0,0 +1,108 @@
[ ... ]
+ phy-names: + minItems: 1 + items: + - const: usb2-phy + - const: usb3-phy + + resets: + minItems: 1
[Severity: Low] Does this resets definition need a maxItems constraint? Without an upper bound, dt-schema allows an arbitrary number of reset items, which might let invalid hardware configurations silently pass validation.
+ + st,syscfg:
[ ... ]
+required: + - compatible + - reg + - clocks + - clock-names + - interrupts + - phys + - phy-names + - resets + - st,syscfg + +unevaluatedProperties: false
[Severity: Medium] Will this strict constraint cause valid USB or DWC3 core properties to be rejected? Since the schema does not include a reference to the core DWC3 schema (such as allOf: - $ref: snps,dwc3.yaml#), only the explicitly listed properties are permitted. Standard properties like maximum-speed, usb-role-switch, or child nodes intended for the DWC3 core will fail validation when checked.
+ +examples: + - |
-- Sashiko AI review · https://sashiko.dev/#/patchset/20260812010157.1772849-1-marex@nabladev.com?part=5