Re: [PATCH v6 02/10] dt-bindings: reset: renesas,rzg2l-usbphy-ctrl: Document RZ/G3L support
From: sashiko-bot@kernel.org
Date: 2026-08-06 10:32:00
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The newly added `regulators` object node lacks the `additionalProperties: false` constraint, allowing arbitrary unvalidated properties inside the node. --
--- Patch [2]: [PATCH v6 02/10] dt-bindings: reset: renesas,rzg2l-usbphy-ctrl: Document RZ/G3L support ---commit e1a3fbe1da9d759b741f1c475a7daaf283958b63 Author: Biju Das [off-list ref] dt-bindings: reset: renesas,rzg2l-usbphy-ctrl: Document RZ/G3L support This commit documents the Renesas RZ/G3L USB PHY controller bindings. It introduces a regulators sub-node with per-port vbus0 and vbus1 entries for the RZ/G3L variant, as it differs from the RZ/G3S.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/reset/renesas,rzg2l-usbphy-ctrl.yaml b/Documentation/devicetree/bindings/reset/renesas,rzg2l-usbphy-ctrl.yaml index c83469a1b379a..9e0c450976573 100644 --- a/Documentation/devicetree/bindings/reset/renesas,rzg2l-usbphy-ctrl.yaml +++ b/Documentation/devicetree/bindings/reset/renesas,rzg2l-usbphy-ctrl.yaml
[ ... ]
quoted hunk ↗ jump to hunk
@@ -50,6 +51,28 @@ properties: $ref: /schemas/regulator/regulator.yaml# unevaluatedProperties: false + regulators: + type: object + description: + list of vbus regulators provided by this controller.
[Severity: Low] Does this regulators object need an additionalProperties: false constraint? Without it, the device tree schema will not reject undefined properties inside the regulators node. Misspelled properties or stray sub-nodes (like vbus2 instead of vbus1) would silently pass schema validation.
+ + properties: + vbus0: + type: object + description: Port 1 USB VBUS regulator
[ ... ] -- Sashiko AI review · https://sashiko.dev/#/patchset/20260806102236.149159-1-biju.das.jz@bp.renesas.com?part=2