On Mon, Feb 02, 2026 at 10:23:43AM +0100, Konrad Dybcio wrote:

On 2/2/26 7:32 AM, Abhinaba Rakshit wrote:

quoted

On Wed, Jan 28, 2026 at 12:04:26PM +0100, Krzysztof Kozlowski wrote:

quoted

On Wed, Jan 28, 2026 at 02:16:41PM +0530, Abhinaba Rakshit wrote:

quoted

 	struct qcom_ice *engine;
+	struct dev_pm_opp *opp;
+	int err;
+	unsigned long rate;
 
 	if (!qcom_scm_is_available())
 		return ERR_PTR(-EPROBE_DEFER);

@@ -584,6 +651,46 @@ static struct qcom_ice *qcom_ice_create(struct device *dev,
 	if (IS_ERR(engine->core_clk))
 		return ERR_CAST(engine->core_clk);
 
+	/* Register the OPP table only when ICE is described as a standalone

This is not netdev...

Okay, if I understand it correct, its not conventional to use of_device_is_compatible
outside netdev subsystem. Will update as mentioned below.

In Linux

/*
 * This style of comments is generally preferred

unless

/* You're contributing to netdev for weird legacy reasons
 * that nobody seems to understand

I see. Thanks for correcting me.
Will keep this in mind while submitting subsequent patches.