Re: [PATCH v4 5/6] ASoC: sophgo: add CV1800B internal DAC codec driver
From: Mark Brown <broonie@kernel.org>
Date: 2026-01-27 12:49:58
Also in:
linux-riscv, linux-sound, lkml
On Tue, Jan 20, 2026 at 11:06:07PM +0400, Anton D. Stavinskii wrote:
help This driver provides an ASoC codec DAI for capture and basic control of the RXADC registers. - Say Y or M to build support for the Sophgo CV1800B internal analog ADC codec block (RXADC). The module will be called cv1800b-sound-adc
Extra change here.
+static int cv1800b_dac_hw_params(struct snd_pcm_substream *substream,
+ struct snd_pcm_hw_params *params,
+ struct snd_soc_dai *dai)
+{
+ struct cv1800b_priv *priv = snd_soc_dai_get_drvdata(dai);
+ int ret;
+ unsigned int rate = params_rate(params);+ cv1800b_dac_mute(priv, false); + /* minimal decimation for 48kHz is 64*/
Nothing ever mutes the DAC so this is a bit redundant. The mute should probably be a mute_stream() operation.
Attachments
- signature.asc [application/pgp-signature] 488 bytes