On 25-09-25 12:59:20, Konrad Dybcio wrote:

On 9/25/25 12:54 PM, Abel Vesa wrote:

quoted

On 25-09-25 11:58:29, Pankaj Patil wrote:

quoted

From: Wesley Cheng <redacted>

The Glymur USB system contains 3 USB type C ports, and 1 USB multiport
controller.  This encompasses 5 SS USB QMP PHYs (3 combo and 2 uni) and 5
M31 eUSB2 PHYs.  The controllers are SNPS DWC3 based, and will use the
flattened DWC3 QCOM design.

Signed-off-by: Wesley Cheng <redacted>
Signed-off-by: Pankaj Patil <redacted>
---

[...]

quoted

quoted

+
+		usb_1_ss0: usb@a600000 {

This is usb_1_ss0, but then you have usb1_ss1 ? 

I'm in favor of just calling it USB0/1/2/MP/HS because that's what it is..

[...]

quoted

quoted

+			dr_mode = "peripheral";
+
+			status = "disabled";

So you have the glue defined above, but not the actual controller (compatible snps,dwc3) ?

I don't see how this would work.

Same for all other controllers.

good morning!

6e762f7b8edc ("dt-bindings: usb: Introduce qcom,snps-dwc3")

Hmm, missed that one.

Fair enough. Scratch that last comment then.