Re: [PATCH v5 2/3] iio: adc: Support ROHM BD79112 ADC/GPIO

On Tue, Sep 16, 2025 at 7:52 AM Matti Vaittinen
[off-list ref] wrote:

On 15/09/2025 23:13, Jonathan Cameron wrote:

quoted

On Mon, 15 Sep 2025 17:12:34 +0300
Andy Shevchenko [off-list ref] wrote:

quoted

On Mon, Sep 15, 2025 at 10:12:43AM +0300, Matti Vaittinen wrote:

...

quoted

quoted

quoted

+   data->vref_mv = ret / 1000;

I still think moving to _mV is the right thing to do.
There is no 'mv' in the physics for Volts.

I'm not disagreeing with this review but I'm also not going to hold a
driver back for that given timing is pretty much such that I merge it
today or it sits a cycle and this one is very near...
I'll get fussier on this once we have written up some guidance and may
well send a patch to modify existing recent cases like this one!

As I replied to Andy, I am disagreeing with this. I hope we won't start
renaming variables with capital letters :(

Why not? In a new code would be nice to have the units properly spelled out.

It seems we have one of the strongest disagreements between us, but I
stand on my position from the angle of the scientific point of view.

-- 
With Best Regards,
Andy Shevchenko