Thread (23 messages) 23 messages, 6 authors, 2025-09-16

Re: [PATCH v4 07/14] arm64: dts: qcom: lemans-evk: Enable PCIe support

From: Sushrut Shree Trivedi <hidden>
Date: 2025-09-15 10:33:28
Also in: linux-arm-msm, linux-i2c, linux-mmc, lkml, netdev

On 9/12/2025 5:57 PM, Konrad Dybcio wrote:
On 9/8/25 10:19 AM, Wasim Nazir wrote:
quoted
From: Sushrut Shree Trivedi <redacted>

Enable PCIe0 and PCIe1 along with the respective phy-nodes.

PCIe0 is routed to an m.2 E key connector on the mainboard for wifi
attaches while PCIe1 routes to a standard PCIe x4 expansion slot.

Signed-off-by: Sushrut Shree Trivedi <redacted>
Signed-off-by: Wasim Nazir <redacted>
---
[...]
quoted
+		perst-pins {
+			pins = "gpio2";
+			function = "gpio";
+			drive-strength = <2>;
+			bias-pull-down;
+		};
Pulling down an active-low pin is a bad idea
Ack, we should do pull up.
we took reference from the previous targets which seems to be wrong.
we will make it pull up.

Bjorn,
can you make this change while applying or shall we send new series.

- Sushrut
Konrad
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help