Re: [PATCH v2 1/8] dt-bindings: memory: tegra210: Add memory client IDs

From
Krzysztof Kozlowski <krzk@kernel.org>
Date
2025-09-05 06:56:59
Also in
linux-pm, linux-tegra, lkml
Reply to
Aaron Kling, 2025-09-04
On 04/09/2025 19:33, Aaron Kling wrote:
On Thu, Sep 4, 2025 at 3:20 AM Krzysztof Kozlowski [off-list ref] wrote:
quoted
On Wed, Sep 03, 2025 at 02:50:07PM -0500, Aaron Kling wrote:
quoted
Each memory client has unique hardware ID, add these IDs.

Signed-off-by: Aaron Kling <redacted>
---
 include/dt-bindings/memory/tegra210-mc.h | 58 ++++++++++++++++++++++++++++++++
 1 file changed, 58 insertions(+)
diff --git a/include/dt-bindings/memory/tegra210-mc.h b/include/dt-bindings/memory/tegra210-mc.h
index 5e082547f1794cba1f72872782e04d8747863b6d..48474942a000e049142014e3bcc132b88bf1a92d 100644
--- a/include/dt-bindings/memory/tegra210-mc.h
+++ b/include/dt-bindings/memory/tegra210-mc.h
@@ -75,4 +75,62 @@
 #define TEGRA210_MC_RESET_ETR                28
 #define TEGRA210_MC_RESET_TSECB              29

+#define TEGRA210_MC_PTCR             0
There is no driver user of this ABI, so does not look like a binding.

You have entire commit msg to clarify such unusual things, like lack of
users. Please use it.
The tegra210-mc driver has these hardcoded and should probably be
updated to use the bindings instead, but I think that's outside of the
scope of this series. I will clarify such in the updated message.
If you introduce the binding, change the drivers to use it. Otherwise
there is no point benefit in this binding, really.
Aaron

Best regards,
Krzysztof
Thread (21 messages) 21 messages, 4 authors, last reply 2025-09-06
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help