Re: [PATCH v3 01/10] dt-bindings: memory: mtk-smi: Document #access-controller-cells
From: Rob Herring <robh@kernel.org>
Date: 2025-08-05 17:53:55
Also in:
linux-arm-kernel, linux-mediatek, linux-pm, lkml
On Tue, Aug 05, 2025 at 09:47:37AM +0200, AngeloGioacchino Del Regno wrote:
quoted hunk ↗ jump to hunk
Some of the SMI Common HW provides access control to at least the power controller: document the #access-controller-cells property and allow specifying it only for MT8183 and MT8365 as those are the only known SoCs with an SMI acting as access controller. Reviewed-by: Nícolas F. R. A. Prado <redacted> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- .../memory-controllers/mediatek,smi-common.yaml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml index 0762e0ff66ef..74b355a08493 100644 --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml@@ -74,6 +74,9 @@ properties: minItems: 2 maxItems: 4 + '#access-controller-cells': + const: 0
I'm still wondering why this is 0? That seems odd that an access controller is 1:1 with a device.
quoted hunk ↗ jump to hunk
+ mediatek,smi: $ref: /schemas/types.yaml#/definitions/phandle description: a phandle to the smi-common node above. Only for sub-common.@@ -168,6 +171,19 @@ allOf: - const: apb - const: smi + - if: # for SMI providing access control + properties: + compatible: + enum: + - mediatek,mt8183-smi-common + - mediatek,mt8365-smi-common + then: + properties: + '#access-controller-cells': true + else: + properties: + '#access-controller-cells': false + additionalProperties: false examples:-- 2.50.1