Thread (23 messages) 23 messages, 7 authors, 2025-07-23

Re: [PATCH V3 3/4] mmc: sdhci-msm: Add Device tree parsing logic for DLL settings

From: Ram Prakash Gupta <hidden>
Date: 2025-07-23 12:02:19
Also in: linux-arm-msm, linux-mmc, lkml

On 7/23/2025 4:07 PM, Konrad Dybcio wrote:
On 7/23/25 12:14 PM, Ram Prakash Gupta wrote:
quoted
On 6/10/2025 5:47 PM, Ram Prakash Gupta wrote:
quoted
Hi Dmitry,

As updated in [PATCH V3 2/2] of this series, I have started now to continue
this work. Will address your comment next.

Thanks,
Ram
[...]
quoted
quoted
quoted
And the pointer to dll_table is lost, lingering for the driver lifetime.
Please drop the devm_ part and kfree() it once it is not used anymore.
ok, I ll allocate memory using kzalloc in function  sdhci_msm_dt_get_array
 and kfree() after copying data in this function.
You can use __free() nowadays (see e.g. drivers/soc/qcom/mdt_loader.c :
mdt_load_split_segment), which will dispose of the memory when it goes
out of scope, limiting the need to clean it up every error path
separately

Konrad
ok thanks, I will use __free()
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help