Re: [PATCH V3 2/4] mmc: sdhci-msm: Add core_major, minor to msm_host structure
From: Dmitry Baryshkov <hidden>
Date: 2025-01-22 09:55:35
Also in:
linux-arm-msm, linux-mmc, lkml
On Wed, Jan 22, 2025 at 03:17:05PM +0530, Sachin Gupta wrote:
This change adds the core_major and core_minor variables to
Please see Documentation/process/submitting-patches.rst, look for "[This patch] makes xyzzy do frotz", then update your internal documentation so that other engineers stop making the same mistake.
quoted hunk ↗ jump to hunk
the msm_host structure, allowing these variables to be accessed more easily throughout the msm_host context. This update is necessary for an upcoming follow-up patch. Signed-off-by: Sachin Gupta <redacted> --- drivers/mmc/host/sdhci-msm.c | 6 ++++++ 1 file changed, 6 insertions(+)diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index e00208535bd1..2a5e588779fc 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c@@ -273,6 +273,8 @@ struct sdhci_msm_host { bool tuning_done; bool calibration_done; u8 saved_tuning_phase; + u8 core_major; + u16 core_minor; bool use_cdclp533; u32 curr_pwr_state; u32 curr_io_level;@@ -2557,6 +2559,10 @@ static int sdhci_msm_probe(struct platform_device *pdev) core_major = (core_version & CORE_VERSION_MAJOR_MASK) >> CORE_VERSION_MAJOR_SHIFT; core_minor = core_version & CORE_VERSION_MINOR_MASK; + + msm_host->core_major = core_major; + msm_host->core_minor = core_minor; + dev_dbg(&pdev->dev, "MCI Version: 0x%08x, major: 0x%04x, minor: 0x%02x\n", core_version, core_major, core_minor);-- 2.17.1
-- With best wishes Dmitry