Re: [PATCH v3 1/2] dt-bindings: i3c: Add adi-i3c-master
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-06-18 09:21:25
Also in:
linux-i3c, lkml
On Wed, Jun 18, 2025 at 09:16:43AM GMT, Jorge Marques wrote:
Add bindings doc for ADI I3C Controller IP core, a FPGA synthesizable IP core that implements the MIPI I3C Basic controller specification.
Here you put outcome of previous questions - why such compatible was chosen, that hardware is this and that.
quoted hunk ↗ jump to hunk
Signed-off-by: Jorge Marques <jorge.marques@analog.com> --- .../devicetree/bindings/i3c/adi,i3c-master.yaml | 63 ++++++++++++++++++++++ MAINTAINERS | 5 ++ 2 files changed, 68 insertions(+)diff --git a/Documentation/devicetree/bindings/i3c/adi,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/adi,i3c-master.yaml new file mode 100644 index 0000000000000000000000000000000000000000..718733bbb450c34c5d4924050cc6f85d8a80fe4b --- /dev/null +++ b/Documentation/devicetree/bindings/i3c/adi,i3c-master.yaml
Filename based on the compatible, so adi,i3c-master-1.00.a.yaml
quoted hunk ↗ jump to hunk
@@ -0,0 +1,63 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/i3c/adi,i3c-master.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices I3C Controller + +description: | + FPGA-based I3C controller designed to interface with I3C and I2C peripherals, + implementing a subset of the I3C-basic specification. + + https://analogdevicesinc.github.io/hdl/library/i3c_controller + +maintainers: + - Jorge Marques <jorge.marques@analog.com> + +properties: + compatible: + const: adi,i3c-master-1.00.a + + reg: + maxItems: 1 + + clocks: + minItems: 1
Why?
+ items: + - description: The AXI interconnect clock. + - description: The I3C controller clock. + + clock-names:
Not synced with clocks.
+ items:
+ - const: axi
+ - const: i3c
+
+ interrupts:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - clock-names
+ - interrupts
+
+allOf:
+ - $ref: i3c.yaml#
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ i3c@44a00000 {
+ compatible = "adi,i3c-master";
+ reg = <0x44a00000 0x1000>;
+ interrupts = <0 56 4>;Use proper defines. Best regards, Krzysztof