Re: [PATCH v1 6/9] dt-bindings: memory: Document Tegra114 External Memory Controller

From
Svyatoslav Ryhel <hidden>
Date
2025-02-26 15:28:19
Also in
linux-clk, linux-tegra, lkml
Reply to
Rob Herring, 2025-02-26
ср, 26 лют. 2025 р. о 17:15 Rob Herring [off-list ref] пише:
On Tue, Feb 25, 2025 at 04:34:58PM +0200, Svyatoslav Ryhel wrote:
quoted
Document External Memory Controller found in the Tegra 4 SoC.
This all looks very close to tegra124. Could have missed something, but
I see 1 property difference and 'nvidia,emc-configuration' is slightly
different. I'd just add tegra114 to the existing schema. For
'nvidia,emc-configuration', I would just list the range for the length.
It's just a list of magic register values, so we can't really do any
validation of it. And I don't care what register is which entry. If you
really want to document that, then keep the existing list and put 0
value entries for any registers that don't exist on tegra114 and put new
registers on the end of the list.
You are totally correct, my first intention was to reuse tegra124
schema, but I did not knew how to handle the timing list correctly.
Tegra114 version does not have one of the entries in that list. I have
tried to use condition to define additional entry but yaml check
continued to complain. Maybe you can show an example where similar
situation is resolved? Thank you.
quoted
Signed-off-by: Svyatoslav Ryhel <redacted>
---
 .../nvidia,tegra114-emc.yaml                  | 431 ++++++++++++++++++
 1 file changed, 431 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/memory-controllers/nvidia,tegra114-emc.yaml
Thread (24 messages) 24 messages, 4 authors, last reply 2025-04-08
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help