Re: [PATCH v1 6/9] dt-bindings: memory: Document Tegra114 External Memory Controller

From
Krzysztof Kozlowski <krzk@kernel.org>
Date
2025-02-25 17:41:53
Also in
linux-clk, linux-tegra, lkml
Reply to
Svyatoslav Ryhel, 2025-02-25
On 25/02/2025 15:34, Svyatoslav Ryhel wrote:
quoted hunk ↗ jump to hunk
+
+properties:
+  compatible:
+    const: nvidia,tegra114-emc
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    items:
+      - const: emc
Drop clock-names
quoted hunk ↗ jump to hunk
+
+  interrupts:
+    maxItems: 1
+
+  "#interconnect-cells":
+    const: 0
+
+  nvidia,memory-controller:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description:
+      phandle of the memory controller node
For what? Your description copies property name and schema, which makes
it useless. Say something not obvious - why this is needed here, what
its purpose is. Do not repeat schema nor property name.
quoted hunk ↗ jump to hunk
+
+  power-domains:
+    maxItems: 1
+    description:
+      Phandle of the SoC "core" power domain.
Drop description, redundant.
quoted hunk ↗ jump to hunk
+
+  operating-points-v2:
+    description:
+      Should contain freqs and voltages and opp-supported-hw property, which is
+      a bitfield indicating SoC speedo ID mask.
+
+patternProperties:
+  "^emc-timings-[0-9]+$":
+    type: object
+    additionalProperties: false
+    properties:
+      nvidia,ram-code:
+        $ref: /schemas/types.yaml#/definitions/uint32
+        description:
+          value of the RAM_CODE field in the PMC_STRAPPING_OPT_A register that
+          this timing set is used for
+
+    patternProperties:
+      "^timing-[0-9]+$":
+        type: object
+        properties:
+          clock-frequency:
+            description:
+              external memory clock rate in Hz
+            minimum: 1000000
+            maximum: 1000000000
+
+          nvidia,emc-auto-cal-config:
+            $ref: /schemas/types.yaml#/definitions/uint32
+            description:
+              value of the EMC_AUTO_CAL_CONFIG register for this set of timings
+
+          nvidia,emc-auto-cal-config2:
+            $ref: /schemas/types.yaml#/definitions/uint32
+            description:
+              value of the EMC_AUTO_CAL_CONFIG2 register for this set of timings
+
+          nvidia,emc-auto-cal-config3:
+            $ref: /schemas/types.yaml#/definitions/uint32
+            description:
+              value of the EMC_AUTO_CAL_CONFIG3 register for this set of timings
+
+          nvidia,emc-auto-cal-interval:
+            description:
+              pad calibration interval in microseconds
User proper unit suffix
+            $ref: /schemas/types.yaml#/definitions/uint32
Drop
quoted hunk ↗ jump to hunk
+            minimum: 0
+            maximum: 2097151
+
Best regards,
Krzysztof
Thread (24 messages) 24 messages, 4 authors, last reply 2025-04-08
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help