Re: [PATCH v4 5/9] dt-bindings: watchdog: renesas: Document `renesas,syscon-cpg-error-rst` property
From: "Rob Herring (Arm)" <robh@kernel.org>
Date: 2025-02-19 21:00:46
Also in:
linux-clk, linux-renesas-soc, linux-watchdog, lkml
On Mon, 10 Feb 2025 18:49:06 +0000, Prabhakar wrote:
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> The CPG block in the RZ/V2H(P) and RZ/G3E SoCs includes Error Reset Select Registers (`CPG_ERRORRST_SELm`) and Error Reset Registers (`CPG_ERROR_RSTm`). The `CPG_ERRORRST_SELm` register must be configured to trigger a system reset in response to specific error conditions, while the `CPG_ERROR_RSTm` registers store the error interrupt factors that caused the system reset. For the watchdog IP to trigger a system reset on a watchdog timer underflow, the `CPG_ERRORRST_SEL2` and `CPG_ERROR_RST2` registers in the CPG block must be configured. For example, setting `BIT(1)` in `CPG_ERRORRST_SEL2` allows WDT1 to issue a system reset upon a watchdog timer underflow. Similarly, `BIT(1)` in `CPG_ERROR_RST2` indicates whether the system reset was caused by a WDT1 underflow. This functionality enables the watchdog driver to configure the `CPG_ERRORRST_SEL2` register and determine whether the system booted due to a `Power-on Reset` or a `Watchdog Reset`. To support this operation, add the `renesas,syscon-cpg-error-rst` property to the WDT node. This property maps to the `syscon` CPG node, allowing the watchdog driver to configure and retrieve the necessary reset information. Additionally, this property is marked as required for the RZ/V2H(P) and RZ/G3E SoC to ensure future compatibility and is explicitly disallowed for other SoCs. Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- Note, this change doesnt break any ABI, as the subsequent driver patch handles the case elegantly if the `syscon` node is missing to handle backward compatibility. v3->v4 - Updated commit message v2->v3 - No change v1->v2 - Renamed `renesas,r9a09g057-syscon-wdt-errorrst` to `renesas,syscon-cpg-error-rst` - Updated commit message --- .../bindings/watchdog/renesas,wdt.yaml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>