Re: [PATCH v2 2/2] gpio: gpio-adg1414: New driver
From: kernel test robot <hidden>
Date: 2025-02-15 01:13:42
Also in:
linux-gpio, lkml, oe-kbuild-all
Hi Kim, kernel test robot noticed the following build warnings: [auto build test WARNING on 4dc1d1bec89864d8076e5ab314f86f46442bfb02] url: https://github.com/intel-lab-lkp/linux/commits/Kim-Seer-Paller/dt-bindings-gpio-add-adg1414/20250213-211900 base: 4dc1d1bec89864d8076e5ab314f86f46442bfb02 patch link: https://lore.kernel.org/r/20250213-for_upstream-v2-2-ec4eff3b3cd5%40analog.com patch subject: [PATCH v2 2/2] gpio: gpio-adg1414: New driver config: alpha-randconfig-r132-20250215 (https://download.01.org/0day-ci/archive/20250215/202502150933.vtaQAJRw-lkp@intel.com/config) compiler: alpha-linux-gcc (GCC) 14.2.0 reproduce: (https://download.01.org/0day-ci/archive/20250215/202502150933.vtaQAJRw-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot [off-list ref] | Closes: https://lore.kernel.org/oe-kbuild-all/202502150933.vtaQAJRw-lkp@intel.com/ (local) sparse warnings: (new ones prefixed by >>)
quoted
drivers/gpio/gpio-adg1414.c:68:31: sparse: sparse: Using plain integer as NULL pointer
drivers/gpio/gpio-adg1414.c: note: in included file (through include/linux/smp.h, include/linux/lockdep.h, include/linux/spinlock.h, ...):
include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
vim +68 drivers/gpio/gpio-adg1414.c
54
55 static void adg1414_set(struct gpio_chip *chip, unsigned int offset, int value)
56 {
57 struct adg1414_state *st = gpiochip_get_data(chip);
58
59 guard(mutex)(&st->lock);
60
61 if (value)
62 st->buf |= BIT(offset);
63 else
64 st->buf &= ~BIT(offset);
65
66 st->tx = cpu_to_be32(st->buf << (32 - st->chip.ngpio));
67
> 68 adg1414_spi_write(st, 0, st->chip.ngpio / 8);
69 }
70
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki