RE: [PATCH v4 3/9] soc: renesas: rz-sysc: Move RZ/G3S SoC detection to the SYSC driver

-----Original Message-----
From: Geert Uytterhoeven <geert@linux-m68k.org>
Sent: Friday, January 24, 2025 3:18 PM
Subject: Re: [PATCH v4 3/9] soc: renesas: rz-sysc: Move RZ/G3S SoC
detection to the SYSC driver

Hi John,

Hi Geert,

Thanks for your review.

On Thu, Jan 23, 2025 at 6:05 PM John Madieu
[off-list ref] wrote:

quoted

From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

Now that we have SoC detection in the RZ SYSC driver, move the RZ/G3S
SoC detection to it. The SYSC provides SoC ID in its own registers.

Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Signed-off-by: John Madieu <john.madieu.xa@bp.renesas.com>

Thanks for your patch!

quoted

+#define SYS_LSI_DEVID_SPECIFIC GENMASK(27, 0)
+#define SYS_MAX_REG            0xe20

Unused.

Will be removed in v5.

quoted

+

The rest LGTM, so with the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

Regards,
John