Re: [PATCH v2 6/8] i2c: qcom-geni: Load i2c qup Firmware from linux side
flat view
From: Dmitry Baryshkov <hidden>
Date: 2025-01-24 15:04:23
Also in:
linux-arm-msm, linux-i2c, linux-serial, linux-spi, lkml
On Fri, Jan 24, 2025 at 04:23:07PM +0530, Viken Dadhaniya wrote:
quoted hunk ↗ jump to hunk
Add provision to load firmware of Serial engine for I2C protocol from Linux Execution Environment on running on APPS processor. Co-developed-by: Mukesh Kumar Savaliya <redacted> Signed-off-by: Mukesh Kumar Savaliya <redacted> Signed-off-by: Viken Dadhaniya <redacted> --- drivers/i2c/busses/i2c-qcom-geni.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c index 7bbd478171e0..9ad3b8c9a224 100644 --- a/drivers/i2c/busses/i2c-qcom-geni.c +++ b/drivers/i2c/busses/i2c-qcom-geni.c@@ -872,8 +872,11 @@ static int geni_i2c_probe(struct platform_device *pdev) } proto = geni_se_read_proto(&gi2c->se); if (proto != GENI_SE_I2C) { - ret = dev_err_probe(dev, -ENXIO, "Invalid proto %d\n", proto); - goto err_resources; + ret = geni_load_se_firmware(&gi2c->se, GENI_SE_I2C);
Hmm, so if the SE has been configured to e.g. SPI by the TZ, can we switch it to the I2C?
+ if (ret) {
+ dev_err(gi2c->se.dev, "i2c firmware load failed ret: %d\n", ret);
+ goto err_resources;
+ }
}
if (desc && desc->no_dma_support)
--
2.34.1-- With best wishes Dmitry