Thread (9 messages) 9 messages, 4 authors, 2025-01-22

Re: [PATCH] dt-bindings: omap: Add TI Pandaboard A4 variant

From: Robert Nelson <hidden>
Date: 2025-01-22 22:36:52
Also in: linux-omap, lkml

On Wed, Jan 22, 2025 at 4:20 PM Andreas Kemnade [off-list ref] wrote:
Am Wed, 22 Jan 2025 08:20:58 -0600
schrieb Tom Rini [off-list ref]:
quoted
On Wed, Jan 22, 2025 at 09:32:36AM +0100, Andreas Kemnade wrote:
quoted
Am Tue, 21 Jan 2025 18:12:40 -0600
schrieb Tom Rini [off-list ref]:
quoted
Document the ti,omap4-panda-a4 compatible string in the appropriate
place within the omap family binding file.

Signed-off-by: Tom Rini <redacted>
---
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Andreas Kemnade <andreas@kemnade.info>
Cc: Kevin Hilman <khilman@baylibre.com>
Cc: Roger Quadros <rogerq@kernel.org>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: linux-omap@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 +
 1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml b/Documentation/devicetree/bindings/arm/ti/omap.yaml
index 93e04a109a12..28e23ca766b4 100644
--- a/Documentation/devicetree/bindings/arm/ti/omap.yaml
+++ b/Documentation/devicetree/bindings/arm/ti/omap.yaml
@@ -137,6 +137,7 @@ properties:
               - motorola,xyboard-mz609
               - motorola,xyboard-mz617
               - ti,omap4-panda
+              - ti,omap4-panda-a4
               - ti,omap4-sdp
           - const: ti,omap4430
           - const: ti,omap4
This allows compatible = "ti,omap4-panda-a4", "ti,omap4430", "ti,omap4"

According to your other patch, you want
compatible = "ti,omap4-panda-a4", "ti,omap4-panda", "ti,omap4430",
"ti,omap4"

so you need a construction similar to the "ti,omap3-beagle-ab4"
Do you mean the order should change, or it should be an enum? I'm not
sure where this is documented (the $id and $schema values in the file
are just 404s so I guess not something to read directly?).
you would need a block like this:

      - description: Early Pandaboard revision A4
        items:
          - const: ti,omap4-panda-a4
          - const: ti,omap4-panda
          - const: ti,omap4430
          - const: ti,omap4
Here's a good table:

https://omappedia.com/wiki/PandaBoard_Revisions#PandaBoard_Revision_History:

The A4 was actually 'late' in the Pandaboard life, sadly the
PandaBoard.org domain went down years ago with no real backup..

The biggest A4 change i've been able to dig up was a change of the i2c
pull ups on the hdmi bus:

https://git.ti.com/gitweb?p=ti-linux-kernel/ti-linux-kernel.git;a=blob;f=arch/arm/boot/dts/omap4-panda-a4.dts;h=f1a6476af3716489007c12141d06f208ec2ebc94;hb=refs/heads/ti-linux-4.14.y

I don't believe I ever saw an A5/A6 in my hands.

Since Panda pre-dates device-tree's normally these would have been named:

ti,omap4-panda-a2 (first production)
ti,omap4-panda-a4

But with this new thing called "device-tree" the A2 got
`ti,omap4-panda` and the newer A4 got `ti,omap4-panda-a4`...

Regards,

-- 
Robert Nelson
https://rcn-ee.com/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help