Thread (9 messages) 9 messages, 4 authors, 2025-01-22

Re: [PATCH] dt-bindings: omap: Add TI Pandaboard A4 variant

From: Tom Rini <hidden>
Date: 2025-01-22 19:52:12
Also in: linux-omap, lkml

On Wed, Jan 22, 2025 at 04:08:27PM +0100, Krzysztof Kozlowski wrote:
On 22/01/2025 15:17, Tom Rini wrote:
quoted
On Wed, Jan 22, 2025 at 09:36:29AM +0100, Krzysztof Kozlowski wrote:
quoted
On 22/01/2025 01:12, Tom Rini wrote:
quoted
Document the ti,omap4-panda-a4 compatible string in the appropriate
place within the omap family binding file.
Why? Where is any user of this? Your commit msg should explain this,
because it's not obvious. Obvious is to send binding with the user, but
the second patch is missing.
You were cc'd on
https://lore.kernel.org/all/20250121200749.4131923-1-trini@konsulko.com/ (local)
I am cc-ed on 200 patches per day and it means nothing. Do you expect me
to look for missing user in 1000 patches per week, for every 1000
patches? Or how does it supposed to work?
Being an overwhelmed maintainer sucks, I really do get that, sorry for
my short reply.
But regardless, the majority of review is done via patchwork and that
DTS patch was not in that thread. It's missing.

You are supposed to send the binding and the user DTS in the same
patchset. Separate makes little sense in case of kernel.

If you need the binding for other projects, then of course above changes
into: always reference the other project submission.
It's fixing a 10 year old regression where the equally viable option is
to just delete the dts file as I'm 99.9% sure no one has even tried
using it in that time.

-- 
Tom
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help