Thread (77 messages) 77 messages, 5 authors, 2025-01-18

Re: [PATCH v1 15/15] iio: adc: ad7768-1: add filter type and decimation rate attributes

From: Jonathan Cameron <jic23@kernel.org>
Date: 2025-01-12 13:04:36
Also in: linux-iio, lkml

On Tue, 7 Jan 2025 17:50:56 -0600
David Lechner [off-list ref] wrote:
On 1/7/25 9:27 AM, Jonathan Santos wrote:
quoted
Separate filter type and decimation rate from the sampling frequency
attribute. The new filter type attribute enables SINC3 and WIDEBAND
filters, which were previously unavailable.  
See related comments in my reply to the documentation patches about wideband vs.
FIR and decimation rate vs. -3dB cutoff.
quoted
Previously, combining decimation and MCLK divider in the sampling
frequency obscured performance trade-offs. Lower MCLK divider
settings increase power usage, while lower decimation rates reduce
precision by decreasing averaging. By creating a decimation attribute,
users gain finer control over performance.  
It seems like we would also want a power_mode attribute. We already have an
attribute for this for used by accelerometers so there is some precedent for
such an attribute.
I'm not sure that attribute was ever a good idea :(
So would prefer we don't use it again unless we are really really stuck.

Usual assumption tends to be if anyone wants to reduce power they
should be able to do so with other controls (i.e. reduce sampling rate or
oversampling). Those are easier to interpret than magic low power mode
attributes.

Jonathan

quoted
The addition of those attributes allows a wider range of sampling
frequencies and more access to the device features.  
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help