Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel

On Fri, 30 Aug 2024, at 7:56 PM, Neil Armstrong wrote:

Thanks Neil,

The only valid compatible with anbernic would be to use the exact 
device in use and not a wildcard,

so you said the 3 devices using this panel are:
  anbernic,rg35xx-2024
  anbernic,rg35xx-plus
  anbernic,rg35xx-h
you should introduce 3 compatibles:
  anbernic,rg35xx-2024-panel
  anbernic,rg35xx-plus-panel
  anbernic,rg35xx-h-panel

but it's duplicating for nothing, to you should use fallbacks for 2 of 
them to have in DT :

  anbernic,rg35xx-2024-panel
  anbernic,rg35xx-plus-panel, anbernic,rg35xx-2024-panel
  anbernic,rg35xx-h-panel, anbernic,rg35xx-2024-panel

and only use anbernic,rg35xx-2024-panel in the driver.

In this case bindings should be like:
   properties:
     compatible:
       oneOf:
         - const: anbernic,rg35xx-2024-panel
         - items:
             - enum:
                 - anbernic,rg35xx-plus-panel
                 - anbernic,rg35xx-h-panel
             - const: anbernic,rg35xx-2024-panel

(of course I selected rg35xx-2024 as the primary one, it could be 
another, usually the older one)

If all are happy with this approach I will resubmit a V2 with that change this evening.

Regards,

Ryan