Got it, LGTM thanks.

-----Original Message-----
From: Potthuri, Sai Krishna <sai.krishna.potthuri@amd.com>
Sent: Monday, September 9, 2024 10:58 PM
To: Thangaraj, Senthil Nathan <redacted>; Linus
Walleij [off-list ref]; Simek, Michal [off-list ref];
Rob Herring [off-list ref]; Krzysztof Kozlowski [off-list ref];
Conor Dooley [off-list ref]; Buddhabhatti, Jay
[off-list ref]; Kundanala, Praveen Teja
[off-list ref]; Greg Kroah-Hartman
[off-list ref]
Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux-
gpio@vger.kernel.org; devicetree@vger.kernel.org;
saikrishna12468@gmail.com; git (AMD-Xilinx) [off-list ref]
Subject: RE: [PATCH v5 2/3] firmware: xilinx: Add Pinctrl Get Attribute ID

Hi Senthil,

quoted

-----Original Message-----
From: Thangaraj, Senthil Nathan <redacted>
Sent: Monday, September 9, 2024 10:33 PM
To: Potthuri, Sai Krishna <sai.krishna.potthuri@amd.com>; Linus
Walleij [off-list ref]; Simek, Michal
[off-list ref]; Rob Herring [off-list ref]; Krzysztof
Kozlowski [off-list ref]; Conor Dooley [off-list ref];
Buddhabhatti, Jay [off-list ref]; Kundanala, Praveen Teja
[off-list ref]; Greg Kroah-Hartman
[off-list ref]
Cc: linux-arm-kernel@lists.infradead.org;
linux-kernel@vger.kernel.org; linux-gpio@vger.kernel.org;
devicetree@vger.kernel.org; saikrishna12468@gmail.com; git
(AMD-Xilinx) [off-list ref]; Potthuri, Sai Krishna
[off-list ref]
Subject: RE: [PATCH v5 2/3] firmware: xilinx: Add Pinctrl Get
Attribute ID

Hi Sai Krishna,

Please find my review below.

Thanks,
Senthil

quoted

-----Original Message-----
From: linux-arm-kernel
[off-list ref]
On Behalf Of Sai Krishna Potthuri
Sent: Friday, September 6, 2024 4:01 AM
To: Linus Walleij <redacted>; Simek, Michal
[off-list ref]; Rob Herring [off-list ref]; Krzysztof
Kozlowski [off-list ref]; Conor Dooley [off-list ref];
Buddhabhatti, Jay [off-list ref]; Kundanala, Praveen
Teja [off-list ref]; Greg Kroah-Hartman
[off-list ref]
Cc: linux-arm-kernel@lists.infradead.org;
linux-kernel@vger.kernel.org; linux- gpio@vger.kernel.org;
devicetree@vger.kernel.org; saikrishna12468@gmail.com; git
(AMD-Xilinx) [off-list ref]; Potthuri, Sai Krishna
[off-list ref]
Subject: [PATCH v5 2/3] firmware: xilinx: Add Pinctrl Get Attribute
ID

Caution: This message originated from an External Source. Use proper
caution when opening attachments, clicking links, or responding.


Add Pinctrl Get Attribute ID to the query ids list.

Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
---
 include/linux/firmware/xlnx-zynqmp.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/firmware/xlnx-zynqmp.h

b/include/linux/firmware/xlnx-zynqmp.h
index d7d07afc0532..3b4ce4ec5d3f 100644

--- a/include/linux/firmware/xlnx-zynqmp.h
+++ b/include/linux/firmware/xlnx-zynqmp.h

@@ -238,6 +238,7 @@ enum pm_query_id {
        PM_QID_PINCTRL_GET_PIN_GROUPS = 11,
        PM_QID_CLOCK_GET_NUM_CLOCKS = 12,
        PM_QID_CLOCK_GET_MAX_DIVISOR = 13,
+       PM_QID_PINCTRL_GET_ATTRIBUTES = 15,

Any reason why do you need to skip 14 and use 15 here ?

This is based on the ID defined in the Xilinx Platform Management Firmware.
Whatever the ID defined by the Xilinx firmware to handle this functionality, the
same ID is used here. ID 14 might be used for another query function but Linux
use cases might not be using it.

Regards
Sai Krishna