RE: [PATCH v5 2/3] firmware: xilinx: Add Pinctrl Get Attribute ID
From: Thangaraj, Senthil Nathan <hidden>
Date: 2024-09-09 17:03:12
Also in:
linux-arm-kernel, linux-gpio, lkml
Hi Sai Krishna, Please find my review below. Thanks, Senthil
quoted hunk ↗ jump to hunk
-----Original Message----- From: linux-arm-kernel <redacted> On Behalf Of Sai Krishna Potthuri Sent: Friday, September 6, 2024 4:01 AM To: Linus Walleij <redacted>; Simek, Michal [off-list ref]; Rob Herring [off-list ref]; Krzysztof Kozlowski [off-list ref]; Conor Dooley [off-list ref]; Buddhabhatti, Jay [off-list ref]; Kundanala, Praveen Teja [off-list ref]; Greg Kroah-Hartman [off-list ref] Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux- gpio@vger.kernel.org; devicetree@vger.kernel.org; saikrishna12468@gmail.com; git (AMD-Xilinx) [off-list ref]; Potthuri, Sai Krishna [off-list ref] Subject: [PATCH v5 2/3] firmware: xilinx: Add Pinctrl Get Attribute ID Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Add Pinctrl Get Attribute ID to the query ids list. Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> --- include/linux/firmware/xlnx-zynqmp.h | 1 + 1 file changed, 1 insertion(+)diff --git a/include/linux/firmware/xlnx-zynqmp.hb/include/linux/firmware/xlnx-zynqmp.h index d7d07afc0532..3b4ce4ec5d3f 100644--- a/include/linux/firmware/xlnx-zynqmp.h +++ b/include/linux/firmware/xlnx-zynqmp.h@@ -238,6 +238,7 @@ enum pm_query_id { PM_QID_PINCTRL_GET_PIN_GROUPS = 11, PM_QID_CLOCK_GET_NUM_CLOCKS = 12, PM_QID_CLOCK_GET_MAX_DIVISOR = 13, + PM_QID_PINCTRL_GET_ATTRIBUTES = 15,
Any reason why do you need to skip 14 and use 15 here ?
};
enum rpu_oper_mode {
--
2.25.1