Re: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver
From: Krzysztof Kozlowski <hidden>
Date: 2023-07-10 06:06:01
Also in:
linux-arm-kernel, linux-media, lkml, llvm, oe-kbuild-all
On 10/07/2023 02:16, yuji2.ishikawa@toshiba.co.jp wrote:
quoted
-----Original Message----- From: kernel test robot <redacted> Sent: Tuesday, June 20, 2023 9:58 PM To: ishikawa yuji(石川 悠司 ○RDC□AITC○EA開) [off-list ref]; Hans Verkuil [off-list ref]; Sakari Ailus [off-list ref]; Laurent Pinchart [off-list ref]; Mauro Carvalho Chehab [off-list ref]; Rob Herring [off-list ref]; Krzysztof Kozlowski [off-list ref]; Conor Dooley [off-list ref]; iwamatsu nobuhiro(岩松 信洋 ○DITC□DIT○OST) [off-list ref] Cc: llvm@lists.linux.dev; oe-kbuild-all@lists.linux.dev; linux-media@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver Hi Yuji, kernel test robot noticed the following build errors: [auto build test ERROR on media-tree/master] [also build test ERROR on linus/master sailus-media-tree/streams v6.4-rc7 next-20230620] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Yuji-Ishikawa/dt-bindings-me dia-platform-visconti-Add-Toshiba-Visconti-Video-Input-Interface-bindings/20 230620-120839 base: git://linuxtv.org/media_tree.git master patch link: https://lore.kernel.org/r/20230620031111.3776-3-yuji2.ishikawa%40toshiba.co.j p patch subject: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver config: x86_64-buildonly-randconfig-r001-20230620 (https://download.01.org/0day-ci/archive/20230620/202306202006.FUjZfd9O-l kp@intel.com/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce: (https://download.01.org/0day-ci/archive/20230620/202306202006.FUjZfd9O-l kp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot [off-list ref] | Closes: | https://lore.kernel.org/oe-kbuild-all/202306202006.FUjZfd9O-lkp@intel. | com/ All errors (new ones prefixed by >>): In file included from <built-in>:1: In file included from ./usr/include/linux/visconti_viif.h:12:quoted
quoted
usr/include/linux/videodev2.h:2464:20: error: field has incomplete type'struct timespec' struct timespec timestamp; ^ usr/include/linux/videodev2.h:2464:9: note: forward declaration of 'struct timespec' struct timespec timestamp; ^ 1 error generated. -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wikiI could not reproduce the error with the steps had been specified. * archived config file didn't compile Visconti VIIF driver (at least, COMPILE_TEST is needed)
That's not true. The config has enabled CONFIG_VIDEO_VISCONTI_VIIF, so your reproduction steps were not correct (e.g. wrong arch, compiler etc).
* the error message didn't appear even if I add some options to config file. * Environment: * OS: Ubuntu 22.04 * compiler: Ubuntu clang version 15.07
Different compilers can have have or not have warnings, but it does not allow to ignore this warning. You can analyze the code even without reproducing it, if the reproduction is a problem. Best regards, Krzysztof