RE: [PATCH v6 1/5] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface bindings
From: <hidden>
Date: 2023-06-21 09:07:34
Also in:
linux-arm-kernel, linux-media, lkml
Hello Krzysztof
-----Original Message----- From: Krzysztof Kozlowski <redacted> Sent: Tuesday, June 20, 2023 3:55 PM To: ishikawa yuji(石川 悠司 ○RDC□AITC○EA開) [off-list ref]; Hans Verkuil [off-list ref]; Sakari Ailus [off-list ref]; Laurent Pinchart [off-list ref]; Mauro Carvalho Chehab [off-list ref]; Rob Herring [off-list ref]; Krzysztof Kozlowski [off-list ref]; Conor Dooley [off-list ref]; iwamatsu nobuhiro(岩松 信洋 ○DITC□DIT○ OST) [off-list ref] Cc: linux-media@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 1/5] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface bindings On 20/06/2023 05:11, Yuji Ishikawa wrote:quoted
Adds the Device Tree binding documentation that allows to describe the Video Input Interface found in Toshiba Visconti SoCs. Signed-off-by: Yuji Ishikawa <redacted> Reviewed-by: Nobuhiro Iwamatsu <redacted> --- Changelog v2: - no change Changelog v3: - no change Changelog v4: - fix style problems at the v3 patch - remove "index" member - update example Changelog v5: - no change Changelog v6: - add register definition of BUS-IF and MPUYou ignored the comments from v4->v5. I pointed this out. You still ignored them. You keep sending the same wrong patch ignoring review. This is not acceptable. NAK
I'm sorry for forgetting applying advice for v4 and v5 patches to this submission. I'll add following changes to the v7 patch. * Remove trailing "bindings" at the commit header, as "dt-bindings:" is already set. * Remove trailing "Device Tree Bindings" from the title. * Fix text wrappings of the description * Update compatible to "toshiba,visconti5-viif" * Update clock-lanes.description "s/line/lane/" * the same with data-lanes.description * remove "unevaluatedProperty:false" from endpoint. put "additionalProperties:false" instead.
Best regards, Krzysztof
Best regards, Yuji Ishikawa