Hi,Dmitry

On Wed, Jun 7, 2023 at 2:51 AM Dmitry Torokhov
[off-list ref] wrote:

On Mon, Jun 05, 2023 at 12:34:54PM +0200, Krzysztof Kozlowski wrote:

quoted

On 05/06/2023 08:05, Cong Yang wrote:

quoted

Add an ilitek touch screen chip ili9882t.

Signed-off-by: Cong Yang <redacted>
---
 .../bindings/input/elan,ekth6915.yaml         | 23 ++++++++++++++++---
 1 file changed, 20 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml
index 05e6f2df604c..f0e7ffdce605 100644
--- a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml
+++ b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml

@@ -15,11 +15,14 @@ description:

 properties:
   compatible:
-    items:
-      - const: elan,ekth6915
+    enum:
+      - elan,ekth6915
+      - ilitek,ili9882t

   reg:
-    const: 0x10
+    enum:
+      - 0x10
+      - 0x41

   interrupts:
     maxItems: 1

@@ -29,11 +32,13 @@ properties:

   vcc33-supply:
     description: The 3.3V supply to the touchscreen.
+                 If using ili9882t then this supply will not be needed.

What does it mean "will not be needed"? Describe the hardware, not your
drivers.

I do not think it makes sense to merge Ilitek and Elan into a single
binding. The only thing that they have in common is that we are trying
to reuse drivers/hid/i2c-hid/i2c-hid-of-elan.c to handle reset timings
(which is also questionable IMO).

Maybe if we had a single unified binding for HID-over-I2C touchscreens
then combining would make more sense, at least to me...

Okay, thanks for the suggestion, I will add an ilitek binding.

Thanks.

--
Dmitry