Re: [PATCH v2 1/2] dt-bindings: input: touchscreen: Add ilitek 9882T touchscreen chip
From: Conor Dooley <conor@kernel.org>
Date: 2023-06-05 10:20:48
Also in:
linux-input, lkml
Hey Cong Yang, On Mon, Jun 05, 2023 at 02:05:23PM +0800, Cong Yang wrote:
Add an ilitek touch screen chip ili9882t.
Could you add a comment here mentioning the relationship between these chips? On Mon, Jun 05, 2023 at 02:05:23PM +0800, Cong Yang wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Cong Yang <redacted> --- .../bindings/input/elan,ekth6915.yaml | 23 ++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-)diff --git a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml index 05e6f2df604c..f0e7ffdce605 100644 --- a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml +++ b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml@@ -15,11 +15,14 @@ description: properties: compatible: - items: - - const: elan,ekth6915 + enum: + - elan,ekth6915 + - ilitek,ili9882t reg: - const: 0x10 + enum: + - 0x10 + - 0x41
Is 0x10 only valid for the elan,ekth6915 & 0x41 for the ilitek one? If so, please add some enforcement of the values based on the compatible.
quoted hunk ↗ jump to hunk
interrupts: maxItems: 1@@ -29,11 +32,13 @@ properties:
vcc33-supply:
description: The 3.3V supply to the touchscreen.
+ If using ili9882t then this supply will not be needed.
vccio-supply:
description:
The IO supply to the touchscreen. Need not be specified if this is the
same as the 3.3V supply.
+ If using ili9882t, the IO supply is required.There's no need for these sort of comments, you can rely on the required sections to describe these relationships. Cheers, Conor.
quoted hunk ↗ jump to hunk
required: - compatible@@ -41,6 +46,18 @@ required: - interrupts - vcc33-supply +if: + properties: + compatible: + contains: + const: ilitek,ili9882t +then: + required: + - compatible + - reg + - interrupts + - vccio-supply + additionalProperties: false examples:-- 2.25.1
Attachments
- signature.asc [application/pgp-signature] 228 bytes