RE: [PATCH 10/16] dt-bindings: PCI: Add phy-names as required property
From: Shradha Todi <hidden>
Date: 2023-03-03 06:24:34
Also in:
linux-arm-kernel, linux-pci, linux-samsung-soc, lkml
From: Shradha Todi <hidden>
Date: 2023-03-03 06:24:34
Also in:
linux-arm-kernel, linux-pci, linux-samsung-soc, lkml
-----Original Message----- From: Rob Herring [mailto:robh@kernel.org] Sent: 15 February 2023 00:48 To: Shradha Todi <redacted> Cc: lpieralisi@kernel.org; kw@linux.com; bhelgaas@google.com; krzysztof.kozlowski+dt@linaro.org; alim.akhtar@samsung.com; jingoohan1@gmail.com; Sergey.Semin@baikalelectronics.ru; lukas.bulwahn@gmail.com; hongxing.zhu@nxp.com; tglx@linutronix.de; m.szyprowski@samsung.com; jh80.chung@samsung.co; pankaj.dubey@samsung.com; linux-pci@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/16] dt-bindings: PCI: Add phy-names as required property On Tue, Feb 14, 2023 at 05:43:27PM +0530, Shradha Todi wrote:quoted
To replace devm_of_phy_get with devm_phy_get to get the PHY pointer using non DT version, we need to add phy-names property in DT and make it a required property with const value.Also an ABI break. And unnecessary. You don't need a name with a single entry. Pretty sure I fixed that for phy_get at some point.
Thanks, I got your point. I will drop this. As of now we have only single PHYs for Samsung and it can be handled via phy_get API without a name as you highlighted. Shradha
Rob