Re: [PATCH v3 2/3] dt-bindings: net: bluetooth: Add NXP bluetooth support

From
Neeraj sanjay kale <neeraj.sanjaykale@nxp.com>
Date
2023-02-21 16:42:03
Also in
linux-bluetooth, linux-serial, lkml, netdev
Reply to
Krzysztof Kozlowski, 2023-02-14
Hi Krzysztof,

Thank you for reviewing this patch. I have fixed all the review comments in this document.
Please let me know if you have any more comments or suggestions on the new v4 patch.
quoted
 .../bindings/net/bluetooth/nxp,w8xxx-bt.yaml  | 44
+++++++++++++++++++
I don't think I proposed such filename.
Renamed file to nxp,w8987-bt.yaml

quoted
+examples:
+  - |
+    uart2 {
This is a friendly reminder during the review process.

It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all requested
changes or keep discussing them.

Thank you.
quoted
+        uart-has-rtscts;
+        bluetooth {
+          compatible = "nxp,iw416-bt";
Wrong indentation. Use 4 spaces for example indentation.
Updated example indentation to use 4 spaces.

Thanks,
Neeraj
Thread (12 messages) 12 messages, 6 authors, last reply 2023-02-21
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help