Re: [PATCH v1 1/4] riscv: dts: starfive: jh7110: Add aon syscon node
From: Changhuang Liang <changhuang.liang@starfivetech.com>
Date: 2023-02-14 02:18:34
Also in:
linux-phy, linux-riscv, lkml
On 2023/2/13 17:28, Krzysztof Kozlowski wrote:
On 10/02/2023 07:17, Changhuang Liang wrote:quoted
Add aon syscon node for the Starfive JH7110 SoC. It can be used by other modules such as DPHY. Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com> --- arch/riscv/boot/dts/starfive/jh7110.dtsi | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi index cfbaff4ea64b..bce3e407ab60 100644 --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi@@ -251,6 +251,11 @@ soc { #size-cells = <2>; ranges; + aon_syscon: aon_syscon@17010000 {No underscores in node names, generic node names.
OK, will change to "syscon".
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendationquoted
+ compatible = "syscon";Nope. syscon cannot be alone. Run dtbs_check before sending DTS.
OK, will fix it.
Best regards, Krzysztof